-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix: recorder ui bug #853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: recorder ui bug #853
Conversation
WalkthroughChanged overflow handling in two UI containers: disabled inner vertical scrolling in the RecordingPage content area and enabled constrained internal scrolling (with hidden scrollbars) in the RightSidePanel layout. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RohitR311 the layout shift still happens. This PR does not fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/components/recorder/RightSidePanel.tsx (1)
539-554: Consider extracting the magic number and consolidating styles.The height calculation
calc(100% - 26px)uses a hardcoded value that may not accurately represent the actual space consumed byActionDescriptionBoxand/or the Box margins. Additionally, mixing inlinestyleprop (line 543) withsxprop reduces consistency.Recommendations:
Extract the height offset as a named constant to improve maintainability:
const ACTION_BOX_HEIGHT_OFFSET = 26; // px - accounts for ActionDescriptionBox heightConsider dynamic calculation if ActionDescriptionBox height can vary:
// Use a ref to measure ActionDescriptionBox actual height const actionBoxRef = useRef<HTMLDivElement>(null); const [actionBoxHeight, setActionBoxHeight] = useState(26);Move inline margin to sx prop for consistency:
<Box display="flex" flexDirection="column" gap={2} - style={{ margin: '13px' }} sx={{ + margin: '13px', height: 'calc(100% - 26px)', overflowY: 'auto',Note on hidden scrollbars: The scrollbar hiding improves visual consistency but may reduce discoverability for users unfamiliar with the interface. Consider adding subtle visual cues (fade effect, scroll indicators) if user testing reveals confusion.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/components/recorder/RightSidePanel.tsx(1 hunks)
🔇 Additional comments (1)
src/components/recorder/RightSidePanel.tsx (1)
537-537: LGTM: Overflow containment on Paper.Adding
overflow: 'hidden'to the Paper component is appropriate to ensure scroll handling occurs within the internal Box rather than on the Paper itself.
What this PR does?
Fixes the UI bug occurring on performing any capture action.
Summary by CodeRabbit