Skip to content

Conversation

@RohitR311
Copy link
Collaborator

@RohitR311 RohitR311 commented Oct 27, 2025

What this PR does?

Fixes the UI bug occurring on performing any capture action.

Summary by CodeRabbit

  • Style
    • Disabled vertical scrolling in the main recording content area, changing how overflow content is displayed and how users scroll within that section.
    • Updated the right-side panel to manage internal scrolling and hide scrollbars, improving layout stability and visual consistency for overflowing content.

@coderabbitai
Copy link

coderabbitai bot commented Oct 27, 2025

Walkthrough

Changed overflow handling in two UI containers: disabled inner vertical scrolling in the RecordingPage content area and enabled constrained internal scrolling (with hidden scrollbars) in the RightSidePanel layout.

Changes

Cohort / File(s) Summary
RecordingPage overflow
src/pages/RecordingPage.tsx
Replaced inner container overflow: auto with overflow: hidden, keeping height at 100% and preventing vertical scrolling inside the BrowserContent/InterpretationLog region.
RightSidePanel scrolling
src/components/recorder/RightSidePanel.tsx
Added overflow: hidden to Paper; set main content Box to height: calc(100% - 26px), overflowY: auto, overflowX: hidden, and applied cross-browser scrollbar-hiding styles to enable internal vertical scrolling without visible scrollbars.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify combined behavior: ensure removing scrolling in RecordingPage doesn't conflict with RightSidePanel internal scrolling.
  • Check cross-browser scrollbar-hiding CSS for regressions (accessibility and keyboard/scroll behavior).
  • Confirm no layout clipping or hidden accessible content occurs in impacted regions.

Possibly related PRs

  • wip: dark mode v1 #829 — Modifies src/components/recorder/RightSidePanel.tsx (overflow/internal scrolling and scrollbar hiding), strongly related to the RightSidePanel changes here.

Suggested labels

Type: Bug, Scope: UI/UX, Scope: Recorder

Suggested reviewers

  • amhsirak

Poem

🐰 A quiet tweak beneath the UI light,
Scrollbars whispered, hidden from sight,
Panels snug in their compact den,
Content tucks in — then hops again,
A rabbit's nod to tidy design ✨

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title 'fix: recorder ui bug' is directly related to the changes in the PR. The modifications address overflow and scrolling behavior in two recorder-related components (RecordingPage.tsx and RightSidePanel.tsx), which are UI-related fixes. The title accurately reflects that this is a UI bug fix for the recorder feature, and the author's description confirms this targets 'the UI bug occurring on performing any capture action.'
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@amhsirak amhsirak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RohitR311 the layout shift still happens. This PR does not fix it.

@RohitR311 RohitR311 requested a review from amhsirak November 3, 2025 16:59
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/components/recorder/RightSidePanel.tsx (1)

539-554: Consider extracting the magic number and consolidating styles.

The height calculation calc(100% - 26px) uses a hardcoded value that may not accurately represent the actual space consumed by ActionDescriptionBox and/or the Box margins. Additionally, mixing inline style prop (line 543) with sx prop reduces consistency.

Recommendations:

  1. Extract the height offset as a named constant to improve maintainability:

    const ACTION_BOX_HEIGHT_OFFSET = 26; // px - accounts for ActionDescriptionBox height
  2. Consider dynamic calculation if ActionDescriptionBox height can vary:

    // Use a ref to measure ActionDescriptionBox actual height
    const actionBoxRef = useRef<HTMLDivElement>(null);
    const [actionBoxHeight, setActionBoxHeight] = useState(26);
  3. Move inline margin to sx prop for consistency:

    <Box
      display="flex"
      flexDirection="column"
      gap={2}
    -  style={{ margin: '13px' }}
      sx={{
    +    margin: '13px',
        height: 'calc(100% - 26px)',
        overflowY: 'auto',
  4. Note on hidden scrollbars: The scrollbar hiding improves visual consistency but may reduce discoverability for users unfamiliar with the interface. Consider adding subtle visual cues (fade effect, scroll indicators) if user testing reveals confusion.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 29146da and e0b5103.

📒 Files selected for processing (1)
  • src/components/recorder/RightSidePanel.tsx (1 hunks)
🔇 Additional comments (1)
src/components/recorder/RightSidePanel.tsx (1)

537-537: LGTM: Overflow containment on Paper.

Adding overflow: 'hidden' to the Paper component is appropriate to ensure scroll handling occurs within the internal Box rather than on the Paper itself.

@amhsirak amhsirak merged commit 0925084 into getmaxun:develop Nov 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants